Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the block inserter, hint that there are more blocks below 'Most Used' #17872

Closed
enriquesanchez opened this issue Oct 9, 2019 · 6 comments
Closed
Assignees
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress

Comments

@enriquesanchez
Copy link
Contributor

Describe the bug
When opening the block inserter, it is not obvious that there are more blocks below 'Most Used' and that I have to scroll.

Screen Shot 2019-10-09 at 4 34 48 PM

Screen Shot 2019-10-09 at 4 44 59 PM

Proposed solution
It'd be more obvious and useful if we hinted that there's more content. I don't think we need an arrow or label to explain this. I think that if we only show a hint of what's below, the interaction should be obvious.

I just reduced the padding and margin for the purpose of this example, but I assume we can also explore other alternatives to achieve this:

Screen Shot 2019-10-09 at 4 36 26 PM

@enriquesanchez enriquesanchez added the Needs Design Feedback Needs general design feedback. label Oct 9, 2019
@karmatosed
Copy link
Member

I love the idea of hinting but I think we can do it without adjusting the visual order around spacing in the block library. We could, for example, grow the library by a few px, or have animation. It would be great to explore what is a good 'hey there is more' way here. Do any other apps have one we can learn from?

@enriquesanchez
Copy link
Contributor Author

We could, for example, grow the library by a few px

I think this would be the simplest approach. That being said, I'm not familiar with why or how we landed on the current height for the inserter popover, so I'd be cautious until someone with more knowledge chimes in. Maybe @mapk?

Do any other apps have one we can learn from?

I think we can gather a lot of inspiration from mobile UI. IMHO they do a really good job of communicating availability of additional content on tight spaces.

Screen Shot 2019-10-10 at 11 54 43 AM

@enriquesanchez
Copy link
Contributor Author

While looking at something else in https://wordpress.org/gutenberg/, I noticed that the inserter used there already does this:

Screen Shot 2019-10-10 at 12 36 39 PM

It seems there are different margin/padding settings:

Screen Shot 2019-10-10 at 12 40 58 PM

@enriquesanchez
Copy link
Contributor Author

Upon further inspecting, it seems that the difference is that the buttons (both the panel toggle and the list items) in the demo page have a line-height: 1;, where the buttons on trunk have different values. Setting them to line-height: 1; gets us similar results:

Screen Shot 2019-10-10 at 1 30 34 PM

Still not ideal though, since 'Common Blocks' is cut off in half and looks more like a quirk instead of something intentional.

@karmatosed
Copy link
Member

karmatosed commented Oct 11, 2019

That being said, I'm not familiar with why or how we landed on the current height for the inserter popover

I can let you know there :) There is no reason it can't grow it was just set that way in first designs. I would be cautious about it growing too much but it absolutely can be explored.

I think we can gather a lot of inspiration from mobile UI. IMHO they do a really good job of communicating availability of additional content on tight spaces.

This feels like a great space to explore and I would love to see more ideas from that space.

@enriquesanchez
Copy link
Contributor Author

Closing in favor of #19836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants