Post visibility unification

[karmatosed]

Currently, the post visibility has 2 styling options for the same content. A baseline would be unify radios, default states and copy formatting.

[enriquesanchez]

The alignment and spacing issues on that second screenshot have been fixed on #17613. This is how they both look on master right now:

I notice a slight variation of color on the text, but upon quickly inspecting the CSS they both seem to have the same color assigned (color: #82878c;). This is odd 🤔.

[richtabor]

It looks like the .editor-post-publish-panel style of color: #555d66; is being applied to the whole panel, styling post visibility properly - whereas .edit-post-post-visibility__dialog-info seems to be inheriting the body color of #444.

I've changed it to #d52411 to show it:

[enriquesanchez]

Oh interesting. Is there any reason why we wouldn't want to use the body color (#444) in this case?

[enriquesanchez]

@karmatosed @richtabor I created a PR (#17731) to fix the text color variation. Please let me know if you have any feedback

[karmatosed]

Oh interesting. Is there any reason why we wouldn't want to use the body color (#444) in this case?

Not sure there is and consistency would be great to start from.