Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase Coverage of Undo/History E2E Tests #17434

Closed
epiqueras opened this issue Sep 13, 2019 · 6 comments · Fixed by #18642
Closed

Increase Coverage of Undo/History E2E Tests #17434

epiqueras opened this issue Sep 13, 2019 · 6 comments · Fixed by #18642
Assignees
@epiqueras
Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Regression Related to a regression in the latest release
Milestone
Future

Comments

@epiqueras
Copy link
Contributor

To catch regressions like the ones fixed in #17420 and #17259.
@epiqueras epiqueras added [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Regression Related to a regression in the latest release labels Sep 13, 2019
@epiqueras epiqueras added this to the Future milestone Sep 13, 2019
@epiqueras epiqueras self-assigned this Sep 13, 2019
@epiqueras epiqueras mentioned this issue Sep 13, 2019
Merged
5 tasks
@mcsf mcsf added the [Priority] High Used to indicate top priority items that need quick attention label Sep 13, 2019
@mcsf
Copy link
Contributor

mcsf commented Oct 21, 2019

@epiqueras would be great to prioritise this one.

@epiqueras
Copy link
Contributor Author

@mcsf Me and @ellatrix have been working on it:

https://github.com/WordPress/gutenberg/commits/d79a8400aa6308c8e2367406c473721bf3ba347f/packages/e2e-tests/specs/undo.test.js

@mcsf
Copy link
Contributor

mcsf commented Nov 8, 2019

@epiqueras, could you revisit this? I'd like to be able to close the issue soonish. 🙏

@epiqueras
Copy link
Contributor Author

I think we're good to close now right @ellatrix ?

I've also made some improvements to the change detection tests.

@ellatrix
Copy link
Member

We certainly have more e2e tests, but there's still no unit tests for the undo reducer at all. We used to have unit tests for withHistory, and any new reducer should ideally be introduced together with some unit tests. Without unit tests, it's hard for anyone else to work on the code. https://github.com/WordPress/gutenberg/blob/0552712059ac5519fad0aeab6dddc5b84f049192/packages/core-data/src/test/reducer.js

@mcsf
Copy link
Contributor

mcsf commented Nov 11, 2019 via email

@epiqueras epiqueras mentioned this issue Nov 20, 2019
Merged
6 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epiqueras epiqueras

Labels
[Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. [Type] Regression Related to a regression in the latest release
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Core Data: Test entity undo reducer. WordPress/gutenberg
3 participants
@mcsf @ellatrix @epiqueras