Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cover Block: Default height cuts off taller content published before 6.4 #17339

Closed
iamtakashi opened this issue Sep 5, 2019 · 1 comment · Fixed by #17365
Closed

Cover Block: Default height cuts off taller content published before 6.4 #17339

iamtakashi opened this issue Sep 5, 2019 · 1 comment · Fixed by #17365
Assignees
Labels
[Status] In Progress Tracking issues with work in progress

Comments

@iamtakashi
Copy link

This issue has already been mentioned in the PR #17143, but I thought it'd be good to open a new issue for it so that it won't be forgotten :)

Since the default value of the new setting "Height in pixels" is added to all the existing cover block in a site, taller content published before 6.4 gets cut off in the editor with the update. (6.4 is on the right)

screen-shot-2019-08-31-at-00 19 47

This is a problem in large sites that have a lot of already published posts and page with the block, and I'm curious about the next step to resolve this if there is any.

@jorgefilipecosta
Copy link
Member

Hi @iamtakashi, @allancole I proposed a PR that refactors the height mechanism #17365 it should fix the problems being faced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants