Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocks Menu Opens Incorrectly on iOS Portrait #1280

Closed
mrjarbenne opened this issue Jun 19, 2017 · 6 comments
Closed

Blocks Menu Opens Incorrectly on iOS Portrait #1280

mrjarbenne opened this issue Jun 19, 2017 · 6 comments
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended

Comments

@mrjarbenne
Copy link

In iOS Safari, the + menu in the top bar opens correctly on iOS in Landscape mode

img_6167

but in portrait mode, the menu opens upwards, sitting above the viewport. You can see the bottom of the menu peeking out from the top in this image:

img_6168

@mrjarbenne
Copy link
Author

Previous screenshots were taken on iPhone 6S. I can confirm similar behaviour on iPad Air. Both instances are on WP Multisite 4.8, with the WP plugin repo version of the Gutenberg plugin: 0.1.0

img_0339

@jasmussen jasmussen added the [Type] Bug An existing feature does not function as intended label Jun 20, 2017
@jasmussen
Copy link
Contributor

Thanks for the report!

@aduth
Copy link
Member

aduth commented Jun 20, 2017

Possibly slated to be resolved by Popover refactoring in #1204.

@jasmussen jasmussen added the Mobile Web Viewport sizes for mobile and tablet devices label Aug 18, 2017
@mtias
Copy link
Member

mtias commented Aug 18, 2017

Closing as fixed by updated popover.

@mtias mtias closed this as completed Aug 18, 2017
@mrjarbenne
Copy link
Author

@mtias I believe this needs to be re-opened.

The updated popover has fixed this issue in landscape, but portrait issues still persist. Using version 0.9 of the plugin, the popover will open upwards. If you switch the orientation while the popover is open, the popover stretches beyond the screen.

2017-08-20_20-16-40

One item to note, which may be worthy of its own issue, but may also be impacting/causing the behaviour:

When the Insert Block button is pressed, the popover opens and the search field is activated, which then triggers the keyboard, and throws everything upwards and out of view (this is also seen in the attached video). Perhaps this is making it difficult for the popover to detect visible real estate.

Related:
#1961
#2471

@karmatosed
Copy link
Member

Closing as we now have a single place to include all issues for mobile inserter in #2691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile Web Viewport sizes for mobile and tablet devices [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

5 participants