Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post title line-height seems high #1271

Closed
melchoyce opened this issue Jun 19, 2017 · 3 comments
Closed

Post title line-height seems high #1271

melchoyce opened this issue Jun 19, 2017 · 3 comments
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.

Comments

@melchoyce
Copy link
Contributor

Current line-height is 1.8, which feels very high:

screen shot 2017-06-19 at 12 14 34 pm

What about something more like 1.4?

screen shot 2017-06-19 at 12 26 08 pm

@melchoyce melchoyce added Design [Type] Enhancement A suggestion for improvement. labels Jun 19, 2017
@jasmussen jasmussen added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Jun 20, 2017
@georgeolaru
Copy link

Nice detail @melchoyce — definitely better! It can be even lower as long as the ascenders and descenders don’t collide.

@jasmussen I know it might not be related specifically to this issue but are there any plans for an Editor Style support, as it is included currently in the TinyMCE editor? In this case, the line height will be better set by the theme, according to the font used.

@jasmussen
Copy link
Contributor

I know it might not be related specifically to this issue but are there any plans for an Editor Style support, as it is included currently in the TinyMCE editor? In this case, the line height will be better set by the theme, according to the font used.

Yes, tracked partially in #422. I know @mtias also has some ideas for a superior replacement that would essentially be like a live preview.

@aduth
Copy link
Member

aduth commented Jun 20, 2017

Closed by #1306

@aduth aduth closed this as completed Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants