Conversion from Classic to Blocks: quote fails to convert correctly

[afercia]

Tested with the quote markup from the "Post Format: Quote" post in the themes unit test data:

<blockquote>Only one thing is impossible for God: To find any sense in any copyright law on the planet.
<cite><a href="http://www.brainyquote.com/quotes/quotes/m/marktwain163473.html">Mark Twain</a></cite></blockquote>

• open in Gutenberg a post with the above content
• the content is displayed correctly in the Classic block, as expected
• in the Classic block "More Options" menu, click "Convert to Blocks"
• the content gets converted to a Quote block with two cite elements:

Code after conversion:

<!-- wp:quote -->
<blockquote class="wp-block-quote"><p>Only one thing is impossible for God: To find any sense in any copyright law on the planet.<br><cite><a href="http://www.brainyquote.com/quotes/quotes/m/marktwain163473.html">Mark Twain</a></cite></p><cite><a href="http://www.brainyquote.com/quotes/quotes/m/marktwain163473.html">Mark Twain</a></cite></blockquote>
<!-- /wp:quote -->

[ellatrix]

@jorgefilipecosta Does your PR #12252 cover this?

[jorgefilipecosta]

Hi @iseulde, unfortunately, #12252 does not cover this problem :(
We may be able to address it with custom transform function, but quote block should not need this, I'm not sure of what is causing the duplication of the citation.

[paaljoachim]

Is this still a valid issue that needs to be fixed?
If so how do we move forward?

@carolinan @talldan @designsimply

[talldan]

Is this still a valid issue that needs to be fixed?

@paaljoachim Can you test it to see if it's still a valid issue?

[paaljoachim]

I did a search and downloaded the theme unit test data from here:
https://make.wordpress.org/themes/handbook/review/theme-unit-test/

Imported it into my test site running WordPress 5.7 beta 3. Went to the post: "Post Format: Quote"
Clicked to convert from Classic to a Quote block.
https://user-images.githubusercontent.com/5323259/108710509-7228bc00-7514-11eb-863c-d811e142bcc2.mp4

I am getting the same result as Andrea did back in 2018.

Convert-Classic-Block-Quote-To-GB-block.mp4

Hopefully this will work correctly in the update of the Quote block to use nested blocks.
#25892

[oandregal]

The PR to allow inner blocks to quote is being worked now #25892 and it's landing by pieces. I've just tested this flow with the PR that adds transforms #39718 and this will be no longer an issue:

Peek.2022-03-28.14-43.mp4

[mtias]

Closed by #25892.