Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with admin_notice #12243

Closed
NicolasKulka opened this issue Nov 23, 2018 · 9 comments
Closed

Problem with admin_notice #12243

NicolasKulka opened this issue Nov 23, 2018 · 9 comments
Assignees
Labels
Backwards Compatibility Issues or PRs that impact backwards compatability [Package] Notices /packages/notices
Milestone

Comments

@NicolasKulka
Copy link

Describe the bug
The admin_notices in the admin goes over the editor

To Reproduce
Edit pages

Screenshot
problem_admin_notice

@nickcernis
Copy link
Contributor

This is particularly noticeable for notices that aren't dismissible:

edit_post_ _wp_beta_ _wordpress

@nerrad
Copy link
Contributor

nerrad commented Nov 24, 2018

related #11604

@desrosj desrosj added the Backwards Compatibility Issues or PRs that impact backwards compatability label Nov 25, 2018
@desrosj
Copy link
Contributor

desrosj commented Nov 25, 2018

This is a must fix for 5.0, IMO.

Related Trac ticket:
https://core.trac.wordpress.org/ticket/45405

@desrosj desrosj added this to the 4.6 milestone Nov 25, 2018
@noisysocks
Copy link
Member

Is it possible to make all notices dismissible?

Otherwise, I think we'll need some design direction here. Perhaps the notices could appear in an invisible scrollable container?

@noisysocks noisysocks added the Needs Design Needs design efforts. label Nov 25, 2018
@nerrad
Copy link
Contributor

nerrad commented Nov 25, 2018

Is it possible to make all notices dismissible?

There's some discussion around this in the pull I linked to (#11604). In particular, this comment: #11604 (comment)

@noisysocks
Copy link
Member

Thanks for the pointer @nerrad!

I'll look into implementing what @aduth describes in #11604 (comment).

I'm unsure if it's too great of a change to be making while we're in the RC phase of 5.0, though. How do we feel about putting overflow: scroll; max-height: 25% on .components-notice-list as an interim fix?

overflow

cc. @jasmussen

@noisysocks noisysocks self-assigned this Nov 26, 2018
@noisysocks
Copy link
Member

I guess it doesn't really solve anything e.g. one can't click on the title field 🙂 — will keep looking into making non-dismissible notices push down the editor.

@aduth
Copy link
Member

aduth commented Nov 26, 2018

A continuation of the design explorations can be found at the addressing pull request #12301

@kriskarkoski
Copy link

Confirmed this on my test site running Gutenberg 4.5.1 while testing a user report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment