From 29bff8571b1338aa8c909859f026d7bd9c50739e Mon Sep 17 00:00:00 2001
From: Jorge Costa <jorge.costa@developer.pt>
Date: Thu, 28 Feb 2019 20:44:41 +0000
Subject: [PATCH] Add array-callback-return rule; Fix current code breaking the
 rule. (#14154)

## Description
Adds a rule to make sure Array functions that iterate on the array and should return something contain the return statement, otherwise, a forEach should probably be used instead.
A case like this was fixed at https://github.com/WordPress/gutenberg/pull/13953.

In PR https://github.com/WordPress/gutenberg/pull/13953 @aduth suggested the implementation of a lint rule to catch these cases. While trying to implement the rule and researching the best ways to do it, I noticed a rule like that already existed in the community and this PR is enabling it.

We are also changing the code to respect the new rule no observable changes should be expected.

## How has this been tested?
Observe the tests pass.
Do some smoke testing, adding blocks, uploading files, and verify everything still works as before.
---
 docs/tool/manifest.js                                         | 2 +-
 packages/block-library/src/file/index.js                      | 2 +-
 packages/edit-post/src/hooks/components/media-upload/index.js | 2 +-
 packages/eslint-plugin/CHANGELOG.md                           | 1 +
 packages/eslint-plugin/configs/es5.js                         | 1 +
 packages/scripts/scripts/check-licenses.js                    | 1 +
 6 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/docs/tool/manifest.js b/docs/tool/manifest.js
index 56f7a2c8772c4b..f21130e448e111 100644
--- a/docs/tool/manifest.js
+++ b/docs/tool/manifest.js
@@ -70,7 +70,7 @@ function getRootManifest( tocFileName ) {
 
 function generateRootManifestFromTOCItems( items, parent = null ) {
 	let pageItems = [];
-	items.map( ( obj ) => {
+	items.forEach( ( obj ) => {
 		const fileName = Object.keys( obj )[ 0 ];
 		const children = obj[ fileName ];
 
diff --git a/packages/block-library/src/file/index.js b/packages/block-library/src/file/index.js
index 1c7087039a5cc9..9ce871bcfa2774 100644
--- a/packages/block-library/src/file/index.js
+++ b/packages/block-library/src/file/index.js
@@ -86,7 +86,7 @@ export const settings = {
 				transform: ( files ) => {
 					const blocks = [];
 
-					files.map( ( file ) => {
+					files.forEach( ( file ) => {
 						const blobURL = createBlobURL( file );
 
 						// File will be uploaded in componentDidMount()
diff --git a/packages/edit-post/src/hooks/components/media-upload/index.js b/packages/edit-post/src/hooks/components/media-upload/index.js
index 0b4fe40ce4ea99..bcf4d49d700c5c 100644
--- a/packages/edit-post/src/hooks/components/media-upload/index.js
+++ b/packages/edit-post/src/hooks/components/media-upload/index.js
@@ -172,7 +172,7 @@ class MediaUpload extends Component {
 		}
 		if ( ! this.props.gallery ) {
 			const selection = this.frame.state().get( 'selection' );
-			castArray( this.props.value ).map( ( id ) => {
+			castArray( this.props.value ).forEach( ( id ) => {
 				selection.add( wp.media.attachment( id ) );
 			} );
 		}
diff --git a/packages/eslint-plugin/CHANGELOG.md b/packages/eslint-plugin/CHANGELOG.md
index 4e3f6f84309962..0d563005b96133 100644
--- a/packages/eslint-plugin/CHANGELOG.md
+++ b/packages/eslint-plugin/CHANGELOG.md
@@ -3,6 +3,7 @@
 ### Breaking Changes
 
 - The `esnext` and `recommended` rulesets now enforce [`object-shorthand`](https://eslint.org/docs/rules/object-shorthand)
+- The `es5` and `recommended` rulesets now enforce [`array-callback-return`](https://eslint.org/docs/rules/array-callback-return)
 
 ### New Features
 
diff --git a/packages/eslint-plugin/configs/es5.js b/packages/eslint-plugin/configs/es5.js
index 167e542ef69a68..a13168d1223e07 100644
--- a/packages/eslint-plugin/configs/es5.js
+++ b/packages/eslint-plugin/configs/es5.js
@@ -1,6 +1,7 @@
 module.exports = {
 	rules: {
 		'array-bracket-spacing': [ 'error', 'always' ],
+		'array-callback-return': 'error',
 		'brace-style': [ 'error', '1tbs' ],
 		camelcase: [ 'error', {
 			properties: 'never',
diff --git a/packages/scripts/scripts/check-licenses.js b/packages/scripts/scripts/check-licenses.js
index 2120d0cbfe75e4..2bc95d51e0913e 100644
--- a/packages/scripts/scripts/check-licenses.js
+++ b/packages/scripts/scripts/check-licenses.js
@@ -258,6 +258,7 @@ modules.forEach( ( path ) => {
 					}, stringDetectedType );
 				}, detectedType );
 			}
+			return detectedType;
 		}, false );
 	}