From 164a1d3a0a175ef44c5f94cbbb8ce98ae3de0136 Mon Sep 17 00:00:00 2001 From: Anton Timmermans Date: Fri, 25 Jan 2019 11:36:36 +0100 Subject: [PATCH] Rename variable to make code more clear --- packages/blocks/src/api/validation.js | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/blocks/src/api/validation.js b/packages/blocks/src/api/validation.js index 4ccf580b8ffdd..6eafa1a1d171a 100644 --- a/packages/blocks/src/api/validation.js +++ b/packages/blocks/src/api/validation.js @@ -553,30 +553,30 @@ export function isEquivalentHTML( actual, expected ) { * * Logs to console in development environments when invalid. * - * @param {string|Object} blockTypeOrName Block type. - * @param {Object} attributes Parsed block attributes. - * @param {string} innerHTML Original block content. + * @param {string|Object} blockTypeOrName Block type. + * @param {Object} attributes Parsed block attributes. + * @param {string} expectedBlockContent Original block content. * * @return {boolean} Whether block is valid. */ -export function isValidBlockContent( blockTypeOrName, attributes, innerHTML ) { +export function isValidBlockContent( blockTypeOrName, attributes, expectedBlockContent ) { const blockType = normalizeBlockType( blockTypeOrName ); - let saveContent; + let actualBlockContent; try { - saveContent = getSaveContent( blockType, attributes ); + actualBlockContent = getSaveContent( blockType, attributes ); } catch ( error ) { log.error( 'Block validation failed because an error occurred while generating block content:\n\n%s', error.toString() ); return false; } - const isValid = isEquivalentHTML( innerHTML, saveContent ); + const isValid = isEquivalentHTML( expectedBlockContent, actualBlockContent ); if ( ! isValid ) { log.error( 'Block validation failed for `%s` (%o).\n\nExpected:\n\n%s\n\nActual:\n\n%s', blockType.name, blockType, - saveContent, - innerHTML + actualBlockContent, + expectedBlockContent ); }