Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to openswoole v22 #3

Open
nbish11 opened this issue Jan 23, 2023 · 1 comment
Open

Move to openswoole v22 #3

nbish11 opened this issue Jan 23, 2023 · 1 comment

Comments

@nbish11
Copy link

nbish11 commented Jan 23, 2023

What are your thoughts about moving from swoole to openswoole for this project? Openswoole v22 now has psr7 support built-in. I was also going to start a WordPress-swoole library until I saw yours. I am more than happy to help.

@superdav42
Copy link
Collaborator

PSR7 support is convenient but practically I think it just means chubbyphp-swoole-request-handler will no longer be necessary. The majority of the code is in https://github.com/WordPress-PSR/request-handler/tree/master/src which I tried to implement in a server agnostic way so it should work in swoole or openswoole. To add support for openswoole all we would need to do is create a different server.php file with a slightly different way of handling the requests. If you want to do that I'd be happy see how it would turn out.

Going forward I can't tell if swoole or openswoole will be the better project to use. I think support both is the way to go for now since it should not be much more work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants