Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shrink/PiP + Mouse Interact] - Implement feature to show where exactly is the mouse in the bigger preview #249

Closed
gileli121 opened this issue Jul 14, 2022 · 20 comments
Labels
done enhancement New feature or request

Comments

@gileli121
Copy link
Member

gileli121 commented Jul 14, 2022

Here are some very first recordings of this implementation

Video.mp4

You get the idea.
But instead of a red box, it will show the mouse cursor

@gileli121 gileli121 added enhancement New feature or request in-progress labels Jul 14, 2022
@gileli121 gileli121 pinned this issue Jul 14, 2022
@gileli121
Copy link
Member Author

After a few hours:

shrink_pip_interact_mouse_clone_v2.mp4

@gileli121
Copy link
Member Author

gileli121 commented Jul 15, 2022

v5.16.0-beta2

  • Fixed DPI issues when screen DPI is higher than 100%
  • Improve the accuracy of the mouse-cursor-clone calculation
  • Set minimum size of the bigger preview when interact mode is enabled...

@Mystqr4
Copy link

Mystqr4 commented Jul 15, 2022

Mouse preview on hover still not working on 5.1.6.beta 2

Edit:
Mouse hover works with the option of "show original window" enabled but not without.

One thing I will mention about the new feature is that the hover preview window with "show original window" is great and all but the hover preview tends to go off screen and I can't see my mouse or the rest of the preview as it goes outside of my monitors view if that makes sense.

I will send you the files now.

@gileli121
Copy link
Member Author

@Mystqr4
We will do the regular process I do with most of the users.
You will send me the settings file and using your settings I should reproduce the issue in most cases (unless there is something outside like system configuration)

Please do the following:

  1. Go to: %appdata%/windowtop
    image
  2. Send me these files to email [email protected]
    image

I am asking to send it in email in private because the settings contain the activation key and it should not be public.

@Mystqr4
Copy link

Mystqr4 commented Jul 15, 2022

edited my post a few moments after you replied.

I will email you the files in a few moments

@gileli121
Copy link
Member Author

gileli121 commented Jul 15, 2022

@Mystqr4
I think that I reproduced it.
If you will resize the shrink box/ pip window to smaller, it will work, right?

Seems that you changed the configuration here:
image

this is while you did not change this option:
image

What it means is that the bigger preview will show up when the size of the PiP window is 120dp or below.
But in the first configuration, you set the default size to 158dp so it will not show the bigger preview from the start.
You need that second configuration will also be 158dp or higher.

May I ask how do you think to call these options in case their meaning is not clear?

About the other issue that it goes out of the screen, I fixed it and also some other issues.

Please try beta 3

Thank you.

@Mystqr4
Copy link

Mystqr4 commented Jul 15, 2022

Oh that explains it. I made the adjustments now and that seemed to have fixed it. I think the terminology is fine maybe a little red text that appears when the user makes adjustments under the "Default Shrink box size" warning people to make adjustments to the "maximum shrink box size for mouse hover too"

It makes perfect sense to me now that you pointed it out. I should have taken note as soon as I made those changes, I imagine most people would have too.

@gileli121
Copy link
Member Author

@Mystqr4
Great.
Thanks for the feedback.
So now everything is ok also with this new feature?
May I ask how you write the text of the note?

@Mystqr4
Copy link

Mystqr4 commented Jul 15, 2022

Great work!
It looks like everything is working as it should as far as I can tell.
The new feature seems to be refined and working well also.

I don't know, maybe something like:
WARNING! Please make adjustments to the maximum shrink box size to compliment the "Default Shrink box size" to avoid issues.

Or

WARNING! Please make adjustments to the maximum shrink box size to compliment the current settings.

@gileli121
Copy link
Member Author

Thank you for your efforts in testing the new functionality!
OK, thanks for the feedback. I will add this small improvement in the settings in the final v5.16 release :)

@Mystqr4
Copy link

Mystqr4 commented Jul 15, 2022

Thank you for your efforts in testing the new functionality! OK, thanks for the feedback. I will add this small improvement in the settings in the final v5.16 release :)

Thanks for the development efforts and implementing so many great features. I will keep testing this software and provide as much feedback as possible where I can to help things along.

@gileli121
Copy link
Member Author

gileli121 commented Jul 17, 2022

@Mystqr4
Thank you!
After more thinking about it, in some cases, I did not like the way that the bigger preview was located and when it overlaps the smaller preview and moves with my mouse.

I decided to change a little how the position is calculated.
Now when INTERACT mode is enabled, the bigger preview will not move and be located as shown here:

shrink_pip_interact_mouse_clone_v2.1_vid2.mp4

The cloned mouse pointer was fixed a little. Now it will not look too upscaled

shrink_pip_interact_mouse_clone_v2.1_vid1.mp4

I am almost finished. In the next beta release, I plan to call this "Read mode" under the INTERACT settings and you will have the option to disable/enable it by default.

Here is beta 4 release:

@Mystqr4
Copy link

Mystqr4 commented Jul 17, 2022

Nice update! It's working pretty great and a lot better imho. The only thing that I could maybe add would be if the preview could be made to maybe not cover the taskbar.
Working pretty great!

I have however noticed that when you shrink notepad.exe and enable interact mode it will be impossible to move the window as it will just begin to highlight the text instead, once interact mode is disabled you can move the window around manually again. This is the only one that I have noticed it doing it with so far.

@gileli121
Copy link
Member Author

@Mystqr4
Great to hear!
About the dragging issue, you should be able to drag it by the title bar if you did not disable it in the settings:
shrink_drag

@Mystqr4
Copy link

Mystqr4 commented Jul 17, 2022

Oh, I did disable that option in the settings and might look at putting that back on perhaps. Coincidentally I had no problems moving notepad++ (which you're using in the example) without the need for extra title bar.

@gileli121
Copy link
Member Author

@Mystqr4
Copy link

Mystqr4 commented Jul 22, 2022

Thank you.
I am currently testing this version.
I have noticed that my toolbar still says shrink rather than PiP but that doesn't bother me at all but I thought I would mention it. It could be a consequence of me being on a beta release prior.

I had to laugh because the in build update check didn't tell me there was a new release again so I just manually updated.

@gileli121
Copy link
Member Author

It is a known issue. These beta builds are also v16.0 so they can't trigger the update notification

@Mystqr4
Copy link

Mystqr4 commented Jul 22, 2022

It is a known issue. These beta builds are also v16.0 so they can't trigger the update notification

Understood. Makes perfect sense now.

Just for consistency is the "Shrink" to "PiP" term going to be present throughout the settings and examples also. I'd imagine it would be less confusing for a new user to see the term Shrink in some places and PiP in others.

I have noticed a few other things but I should probably make another post for those.

@gileli121 gileli121 unpinned this issue Aug 8, 2022
@gileli121
Copy link
Member Author

@Mystqr4
In the last update that was released a few weeks ago, I renamed "Shrink" to "PiP" in all areas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
done enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants