[Toolbar] On window integration alternative

[gileli121]

Discussed in #175

^{Originally posted by SanshooSenshi December 15, 2021}
If there is enough space on the window ( usualy it's always the case, except for many tabs on a browser )
It could be a better workflow if we could have shortcuts displaying instead of waiting for the little "arrow" to show then click on it ...

with a on " mouse over " = no transparency for each options ...

[gileli121]

Can't be done in a way that will work and look fine.
It does not worth the effort

[gileli121]

Similar to this behavior:

I think that I have idea!..

If the mouse is above this button:

Then after 0.5 seconds (or less?) show this:

If this mode is enabled, It will replace the arrow button

Originally posted by @gileli121 in #175 (comment)

And thanks to microsoft/PowerToys#16197 that helped me to get this idea

[gileli121]

I finally developed this behavior:

If there is no minimize button, it will show the regular arrow

Feel free to test:

This is very early stage and for now this behavior is enabled by default and can't be disabled..
It is only because it is alpha. I did not implemented yet the settings UI for controlling this behavior.

Let me know how it works

[cpasoft]

Mmmmm... It sounds promising... This should work also on Windows 10, I suppose, didn't it??
Downloading right now... I'll let you know how it works to me... (now on windows 10, monday on Windows 11)

[gileli121]

Mmmmm... It sounds promising... This should work also on Windows 10, I suppose, didn't it?? Downloading right now... I'll let you know how it works to me... (now on windows 10, monday on Windows 11)

It should work on Windows 10 also.
But I did not tested it there. There was no need for any new special API to make it done

[cpasoft]

Testing on windows 10... working without problem...
The memory leaking on the settings is still there.
I suppose the new keep away algorithm it is not present in this tree, isn't it??
By the moment, it's working great.

[gileli121]

Testing on windows 10... working without problem... The memory leaking on the settings is still there. I suppose the new keep away algorithm it is not present in this tree, isn't it?? By the moment, it's working great.

Great news!
Everything about #194 is not in this tree. In another branch.

About the memory leaking, thanks for the info.
As I suspected, it is not related to #194 changes.

[cpasoft]

On telegram desktop app, it show the green arrow instead of using minimize button...
I guess this is because this app is using an not native window... so it is not windowtop issue... Just I put it here for future references...

[gileli121]

@cpasoft
Actually, it should work even with telegram.
I tested it.
I guess that I broke it, or maybe it is broke in Windows 10

[cpasoft]

On windows 10 is not working on MMC's windows (for example, services.msc)
I'll test this behaivior on Windows 11...

[gileli121]

@cpasoft
What do you mean by saying "not working"?
It works for services.msc in Windows 10

The only issue is that when I try to make it on top, I get this error:

But this is not real issue because the app is not running as Admin. It even telling you what the issue is

[cpasoft]

It is not working to me... It appears the green arrow on the top, not on the minimize icon...

[cpasoft]

Testing on Windows 11, working perfectly... Also working the round corners...

[cpasoft]

Here a video from windows 10...

Screen.Recording.14-02-2022.12-31-08.video-converter.com.mp4

Note: I'm using demo version (not registered). Don't know if this affect to this feature...

[gileli121]

@cpasoft
Thanks. I reproduced it.
And this feature is free also for the Demo version.

At first, it failed to detect the minimize button of this window.
But there is a fallback logic that triggered once you moved the mouse to the minimize button.
At that point, you helped the app to understand that there is minimize button there... so after that it stopped to show the arrow and worked as expected

[cpasoft]

Downloading the beta4 version...
Testing right now...

[cpasoft]

Good & bad news... sorry 'bout that...

Working well on mmc.exe, but still broken on office software...
Word, excel, onenote, ... appear the green arrow and also working on the minimize icon.
In skype we have the green arrow, but not working on the minimize icon...

I suppose it is difficult to detect what kind of window the app is using... You are doing a great job BTW.

[gileli121]

@cpasoft
Thanks!

but still broken on office software...

1. What office version you have installed?
2. Did you tested it on Windows 10 or 11?

[cpasoft]

Office 365, on Windows 10...
Tomorrow I'l test it on Windows 11 if you want...

[gileli121]

@cpasoft
Thanks.
I am installing now office 365 and I will test it also.
I will do it on Windows 11.

I hope to reproduce and fix the bug on my system

[gileli121]

@cpasoft
I tested it with office 365 on windows 11 and it worked without issues.
Maybe it is problem in Windows 10

[gileli121]

@cpasoft
I was able to reproduce the bug on Windows 10 & office 365.
I fixed the bug in beta 5. Feel free to test:

Note that in this version I implemented UI for changing this behavior and it is off by default:

You need to enable the option this time (unlike in old betas)

In addition, now I implemented UI to save and delete window configuration directly from the toolbar

This beta is a candidate to be the next stable release.
I finished implementing all the stuff that needs to be done

[gileli121]

@cpasoft
There was a regression in beta 5 that it detected minimize button here:

Should be fixed now.
Check this please:

Thanks a lot!

[cpasoft]

@cpasoft There was a regression in beta 5 that it detected minimize button here:

Should be fixed now. Check this please:

Thanks a lot!

I'll test this tomorrow... I've seen beta8 on other discussion (French translation, I think). Which is the last beta version??

[gileli121]

@cpasoft
Thanks!
Beta 7 contains the last fix from here and also the French translation.
I prefer that you will try beta 7 from the other discussion (#179).

Thanks

[cpasoft]

Testing Beta7:
On word, excel, onenote and outlook working perfect.
Still not working on Skype,
The green arrow appear on OneDrive as well, but this is correct, because onedrive doesn't have minimize button.

The memory leaking is still there. If you play around the settings, it takes more than 2.5Gb. of memory, and then it will not be free up.
If you have a window open and you change settings, this are not applied to this open windows... you must close this app and reopen again to commit the changes to this window.

I've not seen other issues by the moment...

P.S.: Only tested on Windows 10 machine... I hope I can test it on Windows 11 tomorrow...

[gileli121]

@cpasoft
Thanks, I will mark this issue as done.
About the memory leak issue, I opened issue #202

[gileli121]

@cpasoft
This feature released now in v5.10.0
https://github.com/BiGilSoft/WindowTop/releases/tag/v5.10.0
In addition, the memory leak issue also fixed/reduced a lot (#202)

If there are issues, let me know and I will reopen this issue.
Thanks

[cpasoft]

Well done, very very good work here...
Thanks @gileli121 !!!

[cpasoft]

Testing the brand new 5.10.0
@gileli121 ... I've found another app where this feature doesn't work (Windows 10 & Windows 11)
On the Windows Terminal, the minimize button is not working. It shows the green arrow.

[gileli121]

@cpasoft
I think that it is a bug in Windows Terminal.
Because the OS also does not show this:

When the mouse is above the maximize button.

So maybe you should open the bug in Windows Terminal.
You can open it here: https://github.com/microsoft/terminal/issues
If they will fix the bug that Windows 11 not showing

On the maximize button, they may also fix the bug that the app not showing toolbar on the minimize button.

[cpasoft]

Yes, It must be a bug in Windows Terminal.
Maybe I'll report that... Thanks!