-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working with React 16 #36
Comments
Thanks @ixrock — I'll take a look at supporting React 16.x 👍 |
Hi, the problem is related to DOM Factories are from React 16 upwards available in an external react library called react-dom-factories. Thanks! |
Rendering into a shadow boundary has been resolved, but not yet released. Will update |
Just wondering, seems like that was merged. Should this "just work" again? Or will this library need updates? If someone can confirm it should work I can give it a test. |
There weren't any substantial changes required to make it work with React 16.1.x. However, I've updated the codebase and pushed as All should be good now 👍 Please create new tickets for any issues you may find. |
Error related to https://github.com/Wildhoney/ReactShadow/blob/master/src/react-shadow.js#L293
and might some others..
The text was updated successfully, but these errors were encountered: