Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spool_selected event is also sent when selected spools are loaded #4

Open
WildRikku opened this issue Sep 11, 2024 · 1 comment
Open
Labels
API Concerns the backend interface that can also be used by other plugins bug Something isn't working
Milestone

Comments

@WildRikku
Copy link
Owner

I was confused why the spool_selected event payload appeared in the log every time I uploaded a Gcode file. Turns out that when a file is uploaded or selected, SpoolManager checks if the currently selected spool has enough filament for that file, for which it needs to load the selected spool(s). In my opinion, while that might throw an event, that event should be "spool loaded", not "spool selected", because the selection has not changed.

@WildRikku WildRikku added bug Something isn't working API Concerns the backend interface that can also be used by other plugins labels Sep 11, 2024
@WildRikku WildRikku added this to the 1.7.5 milestone Sep 11, 2024
Copy link

This issue has been automatically marked for closing, because it has not had activity in 30 days. It will be closed if no further activity occurs in 10 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Concerns the backend interface that can also be used by other plugins bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant