Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StudentGreetingChecker repeats greeter queries over and over #6225

Open
ragesoss opened this issue Feb 27, 2025 · 0 comments
Open

StudentGreetingChecker repeats greeter queries over and over #6225

ragesoss opened this issue Feb 27, 2025 · 0 comments
Labels
bug good first issue newcomer friendly performance Rails

Comments

@ragesoss
Copy link
Member

StudentGreetingChecker makes the same username pluck query every time through update_greeting_status. The usernames should only be plucked once for each time StudentGreetingChecker is run. An instance variable with the usernames should fix it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue newcomer friendly performance Rails
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ragesoss