Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Error in decimation of flat plane #17

Closed
HonestHobbit opened this issue Oct 5, 2019 · 3 comments
Closed

Error in decimation of flat plane #17

HonestHobbit opened this issue Oct 5, 2019 · 3 comments

Comments

@HonestHobbit
Copy link

HonestHobbit commented Oct 5, 2019

Sorry to trouble you but I've been doing some testing with your library. I've been using its lossless methods and they seem to hold up great when working with fully enclosed solids, but given a flat plane with no enclosing sides or bottom it cuts a corner off. It's a 16 by 16 subdivided plane I made in blender. The same object with sides and bottom decimates just fine. Can this be fixed or is this algorithm not meant to be applied to non-enclosed solid objects?
Here are the example files;
planes.zip

@Whinarn
Copy link
Owner

Whinarn commented Oct 5, 2019

Hi, @LyingDwarf!

I am aware of this issue.
Please see my comment for a similar issue reported in my other project using the same mesh simplification algorithm: Whinarn/UnityMeshSimplifier#16 (comment)

In short, the algorithm in its current shape isn't very well suited for this. It could most definitely be improved, but I won't be implementing support to deal with planes similar to your needs. Sorry for the inconvenience.

If you manage to get a working solution, I do accept pull requests however.

Thanks!

@HonestHobbit
Copy link
Author

Thanks for the quick response. Since the lossless methods seem to work very well on enclosed solids I may be able to work around the issue by generating fully enclosed solids, simplifying using the lossless methods, and then discarding the extra sides that I don't need.

@Whinarn
Copy link
Owner

Whinarn commented Aug 28, 2020

Closing this issue because the project is being archived. Consider using UnityMeshSimplifier instead, if you are using Unity.

@Whinarn Whinarn closed this as completed Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants