Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cell Border with Color. #116

Closed
IsmailHassanein opened this issue Oct 9, 2015 · 7 comments
Closed

Cell Border with Color. #116

IsmailHassanein opened this issue Oct 9, 2015 · 7 comments

Comments

@IsmailHassanein
Copy link

Hi @WenchaoIOS
I want to show the cells with event to have borders with different colors. I did it before by modfing the background layer of the cell. but it's not the right way to do it as updating overrode my changes. We already talked about it before and you advised me to use the cell image to do that.
I tried to return an image containing the border, but it has some problems.

  1. I couldn't figure out the exact size for the image (my app is universal).
  2. The day number is not centered insid the border as the image alignment to the bottom.
  3. When I change the orientation. the border frame is totaly missed up.
    Something like that is what I want to achieve.
    screen shot 2015-07-14 at 15 46 09

BTW, I have seen @areslui Project and it's a very close to what I want to do.
Image of Yaktocat

Is there any change to create a delegate mothod to allow apply chages to the cell layer?
or do you suggest any other way to achieve this?

Thank you.

@WenchaoD
Copy link
Owner

WenchaoD commented Oct 9, 2015

I'll see what I can do.

Thanks for the coffee BTW~

@WenchaoD
Copy link
Owner

WenchaoD commented Oct 9, 2015

Maybe FSCalendarDelegateAppearance should request both borderColor and fillColor for each date and both selected and unselected state.

@IsmailHassanein
Copy link
Author

Having that would be great and much appriciated.

@WenchaoD
Copy link
Owner

WenchaoD commented Oct 9, 2015

Hi @Ishass

Mind try this branch?
You can look into the Delegate Appearance example for details.

@IsmailHassanein
Copy link
Author

@WenchaoIOS This is Exactlly what I need 👍 👍 . Thank you very much.

@WenchaoD
Copy link
Owner

@Ishass U r welcome.
I'll merge this eventually.

@WenchaoD
Copy link
Owner

This has been merged into master. Closing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants