Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is allowed to happen after last-operation-failed ? #83

Closed
badeend opened this issue Aug 1, 2024 · 2 comments · Fixed by #84
Closed

What is allowed to happen after last-operation-failed ? #83

badeend opened this issue Aug 1, 2024 · 2 comments · Fixed by #84

Comments

@badeend
Copy link
Contributor

badeend commented Aug 1, 2024

The docs for stream-error::closed read:

The stream is closed: no more input will be accepted by the stream.
A closed output-stream will return this error on all future operations.

Should the same apply for stream-error::last-operation-failed ?
I.e.: are errors final or are transient errors allowed?

@pchickey
Copy link

pchickey commented Aug 5, 2024

The intent was that all errors are final - we couldn't come up with a good story for why transient errors should be reported at all through the stream interfaces.

I believe what I intended was for the last-operation-failed to be thrown the first time, and subsequently the stream is always closed.

@badeend
Copy link
Contributor Author

badeend commented Aug 7, 2024

Okay. I've created a PR to clarify this: #84

@badeend badeend closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants