Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Artful Aardvark Support #2189

Merged
merged 2 commits into from
May 8, 2018
Merged

Conversation

JONBRWN
Copy link
Contributor

@JONBRWN JONBRWN commented May 8, 2018

Adds support for Artful Aardvark to the "Installing from Source" sections of our documentation

Adds a new variable called `EXTRA_PONYCFLAGS` for internal use
in the Makefiles to add additional ponyc arguments when needed.
Updates machida Makefile to use the new variable and cleaner
approach.
@@ -169,16 +169,41 @@ cd ~/wallaroo-tutorial/wallaroo/machida
make
```

### Compiling on Artful
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps remove the make line at 169, since the instances of make below are supposed to replace it?

Copy link
Contributor

@slfritchie slfritchie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the one line to fix, the rest looks good, thanks!

Adds supporting documentation for Artful Aardvark in the "From Source"
section.
@JONBRWN JONBRWN force-pushed the add-artful-aardvark-docs-0.4.2 branch from cd15d00 to d663160 Compare May 8, 2018 21:49
@JONBRWN
Copy link
Contributor Author

JONBRWN commented May 8, 2018

@slfritchie fixed, merging

@JONBRWN JONBRWN merged commit 6d37f01 into release-0.4.2 May 8, 2018
@JONBRWN JONBRWN deleted the add-artful-aardvark-docs-0.4.2 branch May 8, 2018 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants