Justify the built-ins. #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iVanlIsh
approved these changes
Apr 15, 2021
mozfreddyb
approved these changes
Apr 19, 2021
index.bs
Outdated
| Note: The normative values of these constants are found below. The derivation | ||
| of these are explained here, with an implementation in the [[DEFAULTS]] | ||
| script. It is expected that these values will change before this | ||
| specifcation is finalized. Also, we expect these |
There was a problem hiding this comment.
Suggested change
| specifcation is finalized. Also, we expect these | |
| specification is finalized. Also, we expect these |
There was a problem hiding this comment.
Done.
(There was a second instance; also fixed.)
index.bs
Outdated
| - The [no-longer conforming](https://html.spec.whatwg.org/#non-conforming-features) | ||
| `<frame>`, `<frameset>`, and `<applet>` tags, which are | ||
| outdated versions companions of several elements listed above. | ||
| - The `<noframes>`, `<noembed>`, and `<nolayer>` elements. |
There was a problem hiding this comment.
Suggested change
| - The `<noframes>`, `<noembed>`, and `<nolayer>` elements. | |
| - The `<noscript>`, `<noframes>`, `<noembed>`, and `<nolayer>` elements. |
There was a problem hiding this comment.
Thank you, done!
otherdaniel
force-pushed
the
justify-defaults
branch
from
8f2f3b9 to
7deccfc
Compare
This was referenced Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This picks up comments from several sources, including our "spec mentor", the TAG, and issue #69. It provides an explanation where our defaults are coming from, and links those to the HTML spec, so that a reader can go back and forth to understand the issue.
Linking is, honestly, best effort since some elements/attributes don't have good link targets. Particularly the legacy / non-conforming ones don't seem to have a "nice" linkable definition in HTML.