Recurse into shadow roots. #189
Conversation
This proposes to recurse into any shadow roots. This follows the discussion at WICG#185
| 1. If |element| is a [=shadow host=]: | ||
| 1. Run the steps of [=sanitize a document fragment=] algorithm on | ||
| |element|'s [=Element/shadow root=]. |
There was a problem hiding this comment.
I suggest adding a note here that this is okay to do since we know our only entry point is the fragment parser.
If we ever have another entry point, such as an arbitrary node, we need a more complicated handshake to not violate encapsulation.
There was a problem hiding this comment.
Also, should this be part of "handle funky elements"? It doesn't matter much but it seems this applies to all elements. But maybe "handle funky element" should be "sanitize an element" and all element-logic should move here?
There was a problem hiding this comment.
If you call into sanitizer a document fragment, you need to pass a Sanitizer instance (I think this).
I too think it might make sense to throw stuff into a "handle element" function. Otherwise looks good.
|
I assume the spec is diverging from this section with your ongoing rewrite. OK to close? |
Yes to both. |
This proposes to recurse into any shadow roots.
This follows the discussion at #185