remove unneeded actions on nova:subscribe

Author: xavxyz

packages/nova-subscribe/lib/mutations.js

@@ -83,7 +83,7 @@ const performSubscriptionAction = (action, collection, itemId, user) => {
   // - the action is subscribe but the user has already subscribed to this item
   // - the action is unsubscribe but the user hasn't subscribed to this item
   if (!subscription || (action === 'subscribe' && subscription.hasSubscribedItem) || (action === 'unsubscribe' && !subscription.hasSubscribedItem)) {
-    throw Error({id: 'app.mutation_not_allowed', value: 'Already subscribed'})
+    throw Error(Utils.encodeIntlError({id: 'app.mutation_not_allowed', value: 'Already subscribed'}))
   }
 
   // shorthand for useful variables
@@ -146,7 +146,7 @@ const performSubscriptionAction = (action, collection, itemId, user) => {
        const { currentUser, [Utils.capitalize(collectionName)]: collection } = context;
 
        // permission check
-       if (!Users.canDo(context.currentUser, `${collectionName}.${action}`) || !Users.canDo(currentUser, `${collectionName}.${action}.all`)) {
+       if (!Users.canDo(context.currentUser, `${collectionName}.${action}`)) {
          throw new Error(Utils.encodeIntlError({id: "app.noPermission"}));
        }
 

packages/nova-subscribe/lib/permissions.js

@@ -10,14 +10,3 @@ const membersActions = [
 ];
 
 Users.groups.members.can(membersActions);
-
-const adminActions = [
-  "posts.subscribe.all",
-  "posts.unsubscribe.all",
-  "users.subscribe.all",
-  "users.unsubscribe.all",
-  "categories.subscribe.all",
-  "categories.unsubscribe.all",
-];
-
-Users.groups.admins.can(adminActions);