remove nova:users’ dependency on nova:emails

Author: SachaG

.meteor/packages

@@ -3,11 +3,11 @@
 nova:core                       # core components and wrappers
 nova:forms                      # auto-generated forms
 nova:routing                    # routing and server-side rendering
-nova:email                      # email
 nova:users                      # user management and permissions
 
 ############ Features Packages ############
 
+nova:email
 nova:posts
 nova:comments
 nova:newsletter
@@ -42,4 +42,4 @@ [email protected]
 # accounts-facebook
 
 # customization-demo
-# framework-demo
+framework-demo

packages/nova-users/lib/callbacks.js

@@ -1,6 +1,5 @@
 import Users from './collection.js';
 import marked from 'marked';
-import NovaEmail from 'meteor/nova:email';
 import { Gravatar } from 'meteor/jparker:gravatar';
 import { addCallback, Utils } from 'meteor/nova:lib'; // import from nova:lib because nova:core isn't loaded yet
 
@@ -83,19 +82,21 @@ function hasCompletedProfile (user) {
 }
 addCallback("users.profileCompleted.sync", hasCompletedProfile);
 
-function usersNewAdminUserCreationNotification (user) {
-  // send notifications to admins
-  const admins = Users.adminUsers();
-  admins.forEach(function(admin) {
-    if (Users.getSetting(admin, "notifications_users", false)) {
-      const emailProperties = Users.getNotificationProperties(user);
-      const html = NovaEmail.getTemplate('newUser')(emailProperties);
-      NovaEmail.send(Users.getEmail(admin), `New user account: ${emailProperties.displayName}`, NovaEmail.buildTemplate(html));
-    }
-  });
-  return user;
-}
-addCallback("users.new.sync", usersNewAdminUserCreationNotification);
+// remove this to get rid of dependency on nova:email
+
+// function usersNewAdminUserCreationNotification (user) {
+//   // send notifications to admins
+//   const admins = Users.adminUsers();
+//   admins.forEach(function(admin) {
+//     if (Users.getSetting(admin, "notifications_users", false)) {
+//       const emailProperties = Users.getNotificationProperties(user);
+//       const html = NovaEmail.getTemplate('newUser')(emailProperties);
+//       NovaEmail.send(Users.getEmail(admin), `New user account: ${emailProperties.displayName}`, NovaEmail.buildTemplate(html));
+//     }
+//   });
+//   return user;
+// }
+// addCallback("users.new.sync", usersNewAdminUserCreationNotification);
 
 function usersEditGenerateHtmlBio (modifier) {
   if (modifier.$set && modifier.$set.bio) {

packages/nova-users/package.js

@@ -10,8 +10,7 @@ Package.onUse(function (api) {
   api.versionsFrom(['[email protected]']);
 
   api.use([
-    'nova:[email protected]',
-    'nova:[email protected]'
+    'nova:[email protected]'
   ]);
 
   api.mainModule("lib/server.js", "server");