-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build with mingw-w64? #117
Comments
@liquidaty hi, I would suggest you try the original project for OSX/Intel platform. While it should be easy to get vectorscan working on this platform, we don't have the hardware and don't intend to support it. However, if the PR is trivial and non-intrusive -ie it doesn't break things for other platforms and is zero/low-cost on maintainance, we would be open to merge it. |
@markos thank you! I appreciate that you will consider it and will send a PR shortly |
Fixed in #121 |
thank you! |
It would be great if this fork supported compilation with mingw-w64.
UPDATE: With some minor modifications, we've managed to compile simplegrep.exe on OSX+mingw-w64. This requires a minor change in src/util/alloc.cpp to use
__mingw_aligned_malloc()
instead ofposix_memalign()
and__mingw_aligned_free()
instead offree()
inaligned_free_internal
.Will you consider incorporating these changes if we create a PR? There are still other issues to resolve (such as getting it to properly use AVX2 instead of only working with SSE), but if if this fork doesn't officially support minGW, this change would at least provide a way to get an unsupported minimal working version with this toolchain, without impacting other builds
The text was updated successfully, but these errors were encountered: