Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https for wordpress develop repo #531

Closed
willenglishiv opened this issue Dec 15, 2014 · 9 comments
Closed

https for wordpress develop repo #531

willenglishiv opened this issue Dec 15, 2014 · 9 comments

Comments

@willenglishiv
Copy link

I saw recently that there was an update to provision.sh in the 1.2 update to turn all the git:// urls to https:// which was awesome. For the longest time I just made the switch in a provision-custom file for my firewall here in the office.

The only repo that seemed to missed the cut was for the wordpress-develop. I switched the repo to @xwp wordpress-develop, as it seems to be a mirror of the private git repo from WP. Is there any official mirror or resource we can use? Is it kosher to PR the other repo in for HTTPS or just keep it custom until WP changes it's mind?

@westonruter
Copy link
Contributor

The WordPress develop Git repo is supposed to be mirrored up on the official WordPress GitHub org very soon. Matt said in the State of the Word that GitHub would happen this year. Once that happens, then the HTTPS protocol can be used for the URL on the GitHub mirror.

Our @xwp mirror is not automatically updating. When working on a new featue branch I'm currently pulling the latest commits from upstream and pushing them up to our mirror. So it only updates manually right now.

@willenglishiv
Copy link
Author

duly noted. I don't have an option behind the firewall and I don't do any wordpress-develop stuff so I guess it's okay for now. Thanks for the reply.

@jeremyfelt
Copy link
Member

And to clarify (I think) - If I remember right, I tried checking out the develop.git repository with HTTPS and it failed as not a valid git repo.

@willenglishiv
Copy link
Author

yeah I should have said that I tried that at first, that's why I switched in my custom provision. I thought someone smarter than me had the inside line but it's all good.

@westonruter
Copy link
Contributor

Oh, I should note how I have this configured:

git remote set-url origin git://develop.git.wordpress.org/
git remote set-url origin --push https://github.com/xwp/wordpress-develop.git

So what this allows me to do is:

git checkout master && git pull && git push

And it will always pull commits from the official Git repo, and then push commits up to our mirror.

I realize this doesn't help you because you can't pull from the git protocol anyway.

@jeremyfelt
Copy link
Member

Ticketed :) https://meta.trac.wordpress.org/ticket/780

@jeremyfelt jeremyfelt added this to the 1.x.x (Future Release) milestone Dec 16, 2014
@willenglishiv
Copy link
Author

Thanks! Looking forward to it.

@jeremyfelt jeremyfelt modified the milestone: Future Release Aug 16, 2016
@jeremyfelt
Copy link
Member

I'm going to close this out now that the wordpress-develop config for VVV has been moved to its own repo in #980. I don't think we're going to see HTTPS on this repo for a while. It should be easier at this point to setup a config that pulls a cloned copy of the develop.wordpress repo instead.

See also: https://meta.trac.wordpress.org/ticket/633

@lock
Copy link

lock bot commented Feb 22, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants