Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it have Macbook support app? #24

Closed
dipankar-npowered opened this issue Oct 2, 2021 · 15 comments · Fixed by #34
Closed

Does it have Macbook support app? #24

dipankar-npowered opened this issue Oct 2, 2021 · 15 comments · Fixed by #34
Labels
bug Something isn't working enhancement New feature or request

Comments

@dipankar-npowered
Copy link

Does it have a Macbook support app? I was trying to build it on my MacBook but getting the following error.

Exception in Tkinter callback
Traceback (most recent call last):
  File "/Users/dipankar/opt/anaconda3/lib/python3.8/tkinter/__init__.py", line 1883, in __call__
    return self.func(*args)
  File "/Users/dipankar/opt/anaconda3/lib/python3.8/tkinter/__init__.py", line 804, in callit
    func(*args)
  File "NSE_Option_Chain_Analyzer.py", line 1571, in main
    self.set_values()
  File "NSE_Option_Chain_Analyzer.py", line 1397, in set_values
    self.sheet.see(last_row)
  File "/Users/dipankar/Projects/Option-Chain-Analysis/env/lib/python3.8/site-packages/tksheet/_tksheet.py", line 1169, in see
    self.MT.see(row, column, keep_yscroll, keep_xscroll, bottom_right_corner, check_cell_visibility = check_cell_visibility, redraw = redraw)
  File "/Users/dipankar/Projects/Option-Chain-Analysis/env/lib/python3.8/site-packages/tksheet/_tksheet_main_table.py", line 1164, in see
    yvis, xvis = self.cell_is_completely_visible(r = r, c = c, separate_axes = True)
  File "/Users/dipankar/Projects/Option-Chain-Analysis/env/lib/python3.8/site-packages/tksheet/_tksheet_main_table.py", line 1220, in cell_is_completely_visible
    x1, y1, x2, y2 = self.GetCellCoords(r = r, c = c, sel = True)
  File "/Users/dipankar/Projects/Option-Chain-Analysis/env/lib/python3.8/site-packages/tksheet/_tksheet_main_table.py", line 2610, in GetCellCoords
    return self.col_positions[c] + 1,self.row_positions[r] + 1, self.col_positions[c + 1], self.row_positions[r + 1]
IndexError: list index out of range

And display is looking like:
Screenshot 2021-10-02 at 11 29 04 AM

@VarunS2002
Copy link
Owner

@dipankar-npowered
Since I don't have one, I'm unable to test it.
However this error seems to be in the tksheet library and not my program, not completely sure though.

@VarunS2002 VarunS2002 added bug Something isn't working enhancement New feature or request labels Oct 4, 2021
@VarunS2002
Copy link
Owner

@dipankar-npowered
Possibly fixed the issue in fd0981c
Downgrade (or upgrade) to version 5.0.24 of tksheet using pip install tksheet==5.0.24 and get back

@VarunS2002
Copy link
Owner

@dipankar-npowered Do all the available features work as expected on a Mac?

@dipankar-npowered
Copy link
Author

@dipankar-npowered Do all the available features work as expected on a Mac?

Yes, it's working as of now.

@VarunS2002
Copy link
Owner

@dipankar-npowered
Could you later help me complete the documentation for MacOS like the one here

@dipankar-npowered
Copy link
Author

I tried to build the app for mac os for you.
Here is the link https://drive.google.com/drive/folders/1XGSEs7ljyE9GniabZ8uLuxDsxNIJW16V?usp=sharing
Some color issues are there. You can check it.

@dipankar-npowered
Copy link
Author

https://drive.google.com/drive/folders/1XGSEs7ljyE9GniabZ8uLuxDsxNIJW16V?usp=sharing

It's in debug mode. You can open by
open -a NSE_Option_Chain_Analyzer.app

@VarunS2002
Copy link
Owner

@dipankar-npowered
That's pretty cool but I don't have a Mac to try it. Correct me if I'm wrong, since python can be installed and programs can be run without building on Mac, I was hoping I'll add instructions for how to do that for users in documentation just like I did for Linux

@dipankar-npowered
Copy link
Author

@dipankar-npowered That's pretty cool but I don't have a Mac to try it. Correct me if I'm wrong, since python can be installed and programs can be run without building on Mac, I was hoping I'll add instructions for how to do that for users in documentation just like I did for Linux

Yes @VarunS2002 All steps are the same in mac to run this codebase as Linux.
Nothing to change.

@VarunS2002
Copy link
Owner

@dipankar-npowered

  • Requirements:

  • Download the .py (Python Source Code) file

  • Required
    modules: requirements.txt

  • Install missing modules using pip install -r requirements.txt

Even these commands are exactly the same?

@VarunS2002
Copy link
Owner

I tried to build the app for mac os for you. Here is the link https://drive.google.com/drive/folders/1XGSEs7ljyE9GniabZ8uLuxDsxNIJW16V?usp=sharing Some color issues are there. You can check it.

Are these color issues present if you run it directly instead of building?

@dipankar-npowered
Copy link
Author

  • Requirements:

    • Python 3.6+

    • Additional steps for Linux:

      • apt-get install python3-tk
      • apt install python3-pip
    • Additional steps for Mac OS:

      • brew install python3
      • brew install python-tk
    • For Windows https://www.python.org/downloads/ is recommended

  • Download the .py (Python Source Code) file

  • Required
    modules: requirements.txt

  • Install missing modules using pip install -r requirements.txt

  • python NSE_Option_Chain_Analyzer.py

@dipankar-npowered
Copy link
Author

I tried to build the app for mac os for you. Here is the link https://drive.google.com/drive/folders/1XGSEs7ljyE9GniabZ8uLuxDsxNIJW16V?usp=sharing Some color issues are there. You can check it.

Are these color issues present if you run it directly instead of building?

No

@VarunS2002
Copy link
Owner

@dipankar-npowered I'm a little busy with work, I'll get back to this soon.

@VarunS2002
Copy link
Owner

@dipankar-npowered Actually I was just checking and turns out that an official Python installer with tk bundled is available on MacOS now so I'll add that. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants