Code clean-up #27
Merged
Code clean-up #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 13, 2024 16:51
this does not yet have feature parity with the previous code, but it is in working condition barring those features
this feature requires more work to be useful in any way. it can be brought back at a later date when more work can be put into it.
clones of `Source` no longer use an `Rc`. `Source` now only uses one `Rc` internally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans-up the current code so that future work will be easier. I've also taken this opportunity to change a few core things that would greatly affect the code-base as their own additions, but allow the clean-up process to be quicker.
Some of the changes include:
Sources are now used to createLexers and are used in errors, as well as other places.Programhas been split-up into separateEngineandContexttypes.Intrinsics are no longer part of the module system, and are instead in their own location.Modules are now namespaced, this feature is subject to change.