357/Python repeatedly starts reload animation if holding down primary attack with prediction enabled

[SamVanheer]

If weapon prediction is enabled and if you fire the 357 until it's empty and continue to hold down the primary attack key, the reload animation is started every frame until you let go of the attack key.

This happens because of this code:

halflife/dlls/python.cpp

Lines 170 to 176 in c7240b9

	if (!m_fFireOnEmpty)
	Reload( );
	else
	{
	EMIT_SOUND(ENT(m_pPlayer->pev), CHAN_WEAPON, "weapons/357_cock1.wav", 0.8, ATTN_NORM);
	m_flNextPrimaryAttack = 0.15;
	}

If m_fFireOnEmpty is false it immediately tries to reload. This code executes every frame on the client which causes the glitchy animation.

It should instead do what the Glock does:

halflife/dlls/wpn_shared/hl_wpn_glock.cpp

Lines 110 to 114 in c7240b9

	if (m_fFireOnEmpty)
	{
	PlayEmptySound();
	m_flNextPrimaryAttack = GetNextAttackDelay(0.2);
	}

The call to Reload needs to be removed. The weapon will reload automatically as soon as the player lets go of the attack key.

This bug was originally reported as part of #617 but was overlooked.

[pierow]

This is happening because of issue #3071. m_fFireOnEmpty would be true if iMaxClip() could return the correct value in client side weapons code.

halflife/cl_dll/hl/hl_weapons.cpp

Lines 352 to 360 in c7240b9

	else if ((m_pPlayer->pev->button & IN_ATTACK) && (m_flNextPrimaryAttack <= 0.0))
	{
	if ( (m_iClip == 0 && pszAmmo1()) || (iMaxClip() == -1 && !m_pPlayer->m_rgAmmo[PrimaryAmmoIndex()] ) )
	{
	m_fFireOnEmpty = TRUE;
	}
	PrimaryAttack();
	}