[GoldSource] Download secondary progress bar doesn't work properly

[s1lentq]

You may notice this when you download a large file using FastDL.
While download a file (e.g >= 100 MB) secondary progress bar always be 100 percent.

Issue is in the function DownloadManager::CheckActiveDownload

In my opinion, a fixes should be like this

Finally, we got the secondary progress bar working correctly

[s1lentq]

#934 related

[fl0werD]

@mikela-valve, please read this topic. Thank you!

[oaus]

@mikela-valve Is there a possibility to add this feature request #934 (comment) , also if Multithreading is too much work then just should just use one progress bar with file size and download speed with the total amount of files that we will download.

Examples:

[R4to0]

also if Multithreading is too much work then just should just use one progress bar with file size and download speed with the total amount of files that we will download.

"Multithreading" is a thing since 2013. If you check active TCP connections you'll notice that 3 files are downloaded at same time (it seems it is set to 5 in the engine, not sure). It just needs to be updated to display them all at same time, or like you suggested, show how many files are being downloaded at that moment.

[Matiarguello]

good gif bb

[mikela-valve]

A fix to the progress bar not updating properly will be included in the next beta update. I won't be adding additional details to the dialog just yet but will consider it for the future and track work on it in #934 if I do.

[mikela-valve]

Fixed in beta 'Exe build: 11:12:36 May 21 2019 (8244)'.

[Mistrick]

now load bar disappeared
connection to server became very fast but without load bar.
i try connect to server with resourses which i don't have and i load all resourses with black screen, console and servers window
load bar exists with new game local server but disappears with internet servers

[mikela-valve]

Sorry, just reproduced this based on your info. Part of this request is serviced in Steam and it looks like I was getting a different response based on the version I was using. I'll update beta later with this working.

[mikela-valve]

This regression should be fixed in the updated beta 'Exe build: 16:32:50 May 22 2019 (8245)'.

[s1lentq]

I can confirm that this issue is fixed in the current beta

[mikela-valve]

Closing as fixed.