From f60467cd4d5583de7f0eec8d14bb8e8e591d549e Mon Sep 17 00:00:00 2001 From: Vaibhav Malik <34866732+VaibhavMalik4187@users.noreply.github.com> Date: Sat, 16 Mar 2024 00:15:36 +0530 Subject: [PATCH] test: added missing tests for the Netpool analyzer (#1016) - Added a network policy allowing traffic to all pods. Resulting in additional failures in the results. Partially addresses: https://github.com/k8sgpt-ai/k8sgpt/issues/889 Signed-off-by: VaibhavMalik4187 Co-authored-by: Alex Jones --- pkg/analyzer/netpol_test.go | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/pkg/analyzer/netpol_test.go b/pkg/analyzer/netpol_test.go index 23eb6acb0f..b06318e187 100644 --- a/pkg/analyzer/netpol_test.go +++ b/pkg/analyzer/netpol_test.go @@ -136,6 +136,19 @@ func TestNetpolWithPod(t *testing.T) { func TestNetpolNoPodsNamespaceFiltering(t *testing.T) { clientset := fake.NewSimpleClientset( + &networkingv1.NetworkPolicy{ + ObjectMeta: metav1.ObjectMeta{ + Name: "policy-without-podselector-match-labels", + Namespace: "default", + }, + Spec: networkingv1.NetworkPolicySpec{ + PodSelector: metav1.LabelSelector{ + // len(MatchLabels) == 0 should trigger a failure. + // Allowing traffic to all pods. + MatchLabels: map[string]string{}, + }, + }, + }, &networkingv1.NetworkPolicy{ ObjectMeta: metav1.ObjectMeta{ Name: "example", @@ -203,7 +216,7 @@ func TestNetpolNoPodsNamespaceFiltering(t *testing.T) { t.Error(err) } - assert.Equal(t, len(results), 1) + assert.Equal(t, len(results), 2) assert.Equal(t, results[0].Kind, "NetworkPolicy") }