Pasting to replace lines inserts extra empty lines

[viraptor]

• Click thumbs-up 👍 on this issue if you want it!
• Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG REPORT

Environment:

• VSCode Version: 1.14.0
• VsCodeVim Version: 0.9.0
• OS: MacOS

What happened:

• Yank a single line (yy)
• Go to another line
• Select line (V)
• Paste to replace it (p)

The highlighted line was replaced with two - one empty line, one pasted.

What did you expect to happen:

No empty line pasted. (vim's behaviour)

How to reproduce it:

On a file with:

first line
second line

Executing ggyyjVp results in:

first line

first line

[xconverge]

related probably #1911

[cvharris]

Experiencing this exact thing too. Was thinking I just didn't know how to vim

[kristiandupont]

This seems to happen when pasting from normal mode as well.

[tyru]

I missed this issue, but #2579 already fixed this.

[jpoon]

Tried to repro on master, looks to be fixed.