Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong cursor placement after indenting multiple lines #1135

Closed
mklinga opened this issue Dec 7, 2016 · 6 comments
Closed

Wrong cursor placement after indenting multiple lines #1135

mklinga opened this issue Dec 7, 2016 · 6 comments
Labels

Comments

@mklinga
Copy link

mklinga commented Dec 7, 2016

Please thumbs-up 👍 this issue if it personally affects you! You can do this by clicking on the emoji-face on the top right of this post. Issues with more thumbs-up will be prioritized.


What did you do?

Select multiple lines with linewise-select (shift+v)
Indent them with < or >
Press k or j

What did you expect to happen?

Indent the lines, and move the cursor one line up/down from the first line of the selection.

What happened instead?

The lines were indented correctly, but the cursor movement after the indentation started from the last line of the (cleared) selection instead of the first, despite the cursor showing on the first line of the selection after they have been indented.

Technical details:

  • VSCode Version: 1.7.2
  • VsCodeVim Version: 0.4.9
  • OS: macOS Sierra
@mklinga
Copy link
Author

mklinga commented Dec 9, 2016

Just a side note - this was a regression on the v0.4.9, on the version v0.4.8 and prior the cursor position was correct.

@johnfn
Copy link
Member

johnfn commented Dec 9, 2016

Ahh, pointing that out is really helpful. I know why this is: 648dbf9

Easy bug fix to whoever wants it. Otherwise I'll get to it in the next few days. 😄

@johnfn johnfn added the kind/bug label Dec 9, 2016
@xconverge
Copy link
Member

This seems to be all good now?

@mklinga
Copy link
Author

mklinga commented Dec 24, 2016

Still seeing the issue with version 0.4.10.

I did some digging and found out that the culprit is the following line on my config:

"vim.useSolidBlockCursor": true,

If I remove that line from the config, the cursor positioning is always correct, but with the solidBlockCursor enabled it gets the position wrong.

@sashee
Copy link

sashee commented Mar 7, 2017

Still seeing this issue in 0.6.2.

Disabling vim.useSolidBlockCursor fixes it.

@jpoon
Copy link
Member

jpoon commented May 19, 2017

I believe this is fixed by #1402. Please re-open if that's not the case.

@jpoon jpoon closed this as completed May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants