fix: use existing convention for sdk name (#699)

Unleash · Jan 21, 2025 · e26a700 · e26a700
1 parent b558693
commit e26a700
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/request.ts b/src/request.ts
@@ -101,7 +101,7 @@ export const buildHeaders = ({
     head['Unleash-Client-Spec'] = specVersionSupported;
   }
   const version = details.version;
-  head['x-unleash-sdk'] = `unleash-node@${version}`;
+  head['x-unleash-sdk'] = `unleash-client-node:${version}`;
   if (custom) {
     Object.assign(head, custom);
   }

diff --git a/src/test/metrics.test.ts b/src/test/metrics.test.ts
@@ -130,12 +130,12 @@ test('should send correct custom and x-unleash headers', (t) =>
     const metricsEP = nockMetrics(url)
       .matchHeader('randomKey', randomKey)
       .matchHeader('x-unleash-appname', 'appName')
-      .matchHeader('x-unleash-sdk', /^unleash-node@\d+\.\d+\.\d+/)
+      .matchHeader('x-unleash-sdk', /^unleash-client-node:\d+\.\d+\.\d+/)
       .matchHeader('x-unleash-connection-id', 'connectionId');
     const regEP = nockRegister(url)
       .matchHeader('randomKey', randomKey)
       .matchHeader('x-unleash-appname', 'appName')
-      .matchHeader('x-unleash-sdk', /^unleash-node@\d+\.\d+\.\d+/)
+      .matchHeader('x-unleash-sdk', /^unleash-client-node:\d+\.\d+\.\d+/)
       .matchHeader('x-unleash-connection-id', 'connectionId');
 
     // @ts-expect-error

diff --git a/src/test/repository.test.ts b/src/test/repository.test.ts
@@ -191,7 +191,7 @@ test('should request with correct custom and x-unleash headers', (t) =>
       .matchHeader('randomKey', randomKey)
       .matchHeader('x-unleash-appname', appName)
       .matchHeader('x-unleash-connection-id', connectionId)
-      .matchHeader('x-unleash-sdk', /^unleash-node@\d+\.\d+\.\d+/)
+      .matchHeader('x-unleash-sdk', /^unleash-client-node:\d+\.\d+\.\d+/)
       .persist()
       .get('/client/features')
       .reply(200, { features: [] }, { Etag: '12345-3' });

diff --git a/src/test/request.test.ts b/src/test/request.test.ts
@@ -29,5 +29,5 @@ test('Correct headers should be included', (t) => {
   t.is(headers['UNLEASH-INSTANCEID'], 'instanceId');
   t.is(headers['x-unleash-connection-id'], 'connectionId');
   t.is(headers['x-unleash-appname'], 'myApp');
-  t.regex(headers['x-unleash-sdk'], /^unleash-node@\d+\.\d+\.\d+/);
+  t.regex(headers['x-unleash-sdk'], /^unleash-client-node:\d+\.\d+\.\d+/);
 });