Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Fix TWAMM & Test #101

Closed
saucepoint opened this issue Mar 15, 2024 · 1 comment
Closed

[Bug]: Fix TWAMM & Test #101

saucepoint opened this issue Mar 15, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@saucepoint
Copy link
Collaborator

Describe the bug

There's a breaking bug in TWAMM, where downstream code of beforeSwap is relocking with the PoolManager. With recent changes to PoolManager, relocking/nested locks will now revert.

The relock is not caught because we are not triggering beforeSwap (no swaps) in the tests.

Expected Behavior

Remove relocking behavior. Add a test to TWAMM.t.sol which triggers beforeSwap

To Reproduce

No response

Additional context

#100 (comment)
@saucepoint saucepoint added the bug Something isn't working label Mar 15, 2024
@saucepoint
Copy link
Collaborator Author

hmm dont think this is an issue anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@saucepoint