-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialize members of vldata to make sure that nc_free_vlens() succeeds. See #527. #605
Conversation
Note that free(NULL) is a no-op.
Could @dopplershift 's test from issue #527 be added to tst_vlen.py along with a Changelog entry? |
@jswhit Absolutely! |
Note that Travis CI uses NetCDF 4.1.1 while AppVeyor has 4.3.3.1. I'll post an update once I have more info. (I'll have to install NetCDF and HDF5 versions matching ones used by Travis CI scripts.) |
4.3 can be installed in travis ci trusty |
The travis tests still fail even with hdf5-1.8.15-patch1 and necdf-4.4.0 (see pull request #606). Works fine for me on OSX. Maybe it's related to the compiler toolchain? |
I'd like to go ahead and merge this, since it is the right thing to do. Let's just disable the test for right now until we figure out why it fails on Ubuntu. |
@jswhit If I understand this correctly, the test I added will fail with NetCDF versions < 4.4.1 (see Unidata/netcdf-c#221). I have no idea why it passed on AppVeyor (I blame it on the undefined behavior of |
Let's wrap the test with |
@jswhit Regarding turning the test off for NetCDF < 4.4.1: I did this already (please see the code). (One of AppVeyor checks failed during " |
OK, great. Merging now then. |
Note that
free(NULL)
is a no-op.