Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed some issues #957

Closed

Conversation

edhartnett
Copy link
Contributor

Fixes #955
Fixes #926.

These two fixes are needed for #856.

@WardF
Copy link
Member

WardF commented May 8, 2018

Thanks! Rolling it in with the other PR's I'm merging as part of the pr-consolidate.wif branch right now.

@WardF WardF self-assigned this May 8, 2018
@WardF WardF added this to the 4.7.0 milestone May 8, 2018
@edhartnett
Copy link
Contributor Author

@WardF sorry, I just realized that I didn't need to merge in master, since you've already taken in these changes on another branch. Whoops!

@WardF
Copy link
Member

WardF commented May 8, 2018

No worries, it will all shake out with git!

@edhartnett
Copy link
Contributor Author

These changes got merged via another PR, so I will close this one.

@edhartnett edhartnett closed this May 10, 2018
@edhartnett edhartnett deleted the ejh_fix_n3 branch May 18, 2018 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants