Fix for bug renaming non-coord var to same name as dim without a var #1298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edhartnett
changed the title
|
@WardF can we get this merged soon? I have some more rename fixes, and then a comprehensive rename fix that I think will solve many or all of the remaining rename problems... |
|
I will wrap this and some other prs into an aggregation in short order! Have a great weekend.
…On Jan 31, 2019, 8:00 AM -0700, Ed Hartnett ***@***.***>, wrote:
@WardF can we get this merged soon? I have some more rename fixes, and then a comprehensive rename fix that I think will solve many or all of the remaining rename problems...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #597.
Fixes #1297.
This is a fix for a tricky rename bug.
This PR includes all my pending PRs. It may be easier to review this code after some of them get merged.