Fix some issues, add comments, and prepare for lazy(-ish) var reads #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ooping through the names
… already-identified dims
…t to find dimids if available
|
I’m at AGU this week, but should be able to queue up this and a few others in a combined PR shortly. I’m 2 hours in the future so by the time you reach this point along the continuum they should be merge-ready |
|
Merging into aggregation as I get caught up post-holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some speedups for file opens which are lazy reads of part of the variable metadata (see discussion in #489). There is also a dimscale matching optimization I will propose, and this prepares for that (see #865).
The changes in this PR are in preparation for the lazy read code. The changes in this PR are code cleanup, additional documentation, and fixing some error handling issues in the existing code. Some functions which are only used in one place are made static instead of global, and some long functions are broken down by adding some static functions to do some of the heavy lifting.
Fixes #1247.
Fixes #1241.