Fix some more C++ style comments #1236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ossibility of netcdf-4 build without hdf5
|
Interesting note. Cywin with -ansi does not define strdup() (and maybe other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added an -ansi build to my CI, and caught the C++ style comments that are fixed in this PR.
None of the nc_test4 tests work with -ansi. All of them segfault in the function NC_rcload().
@DennisHeimbigner not clear what you are doing in this function, but you might want to take a look to see what non-ansi C thing you are doing in there.
Also the ocprint.c program fails. I just did a --disable-dap at this point. (Shouldn't this turn off reading the rc file? Isn't that for DAP only?).
This PR is in the queue behind #1234 and includes that PR. (I will take down this PR because these changes should be reviewed. Once #1234 is merged I will submit this PR again.)