-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Next step in HDF5 separation - var info #1194
Closed
edhartnett
wants to merge
29
commits into
Unidata:master
from
NetCDF-World-Domination-Council:ejh_next_7
Closed
Next step in HDF5 separation - var info #1194
edhartnett
wants to merge
29
commits into
Unidata:master
from
NetCDF-World-Domination-Council:ejh_next_7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@WardF can we get this one merged to master soon? There's a lot of changes and I'm afraid they will go stale if someone else starts working on this code. Thanks! |
I am going to take this PR down, because it is included in other PRs now pending. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #856.
Moving the HDF5 fields from NC_VAR_INFO_T to new stuct NC_HDF5_VAR_INFO_T and moving code to handle them to libhdf5.