Separate the closing of HDF5 objects from freeing of internal metadata #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ret: Unidata#1162 The test nc_test/run_diskless2.sh fails when LARGE_FILE_TESTS is enabled. Since the goal of the test was to test out diskless+persist on a reasonably large file, I fixed by just limiting the file size to 1000000000L bytes.
|
Merging into 4.6.2 release branch, which will be merged upstream in short order. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #856.
This is almost the end of the separation of HDF5 code from libsrc4 code. In this PR I add a new recursive close for the file, which closes all open HDF5 objects. The libsrc4 recursive close no longer has to deal with HDF5 objects, but frees internal metadata and lists.
After this is merged, the final steps will be to move the rest of the HDF5 specific pointers from the nc4internal.h structs and into HDF5 structs.
This is not urgent and does not have to be part of the release, if the release is imminent.
(Also this PR includes fixes from @DennisHeimbigner for memory leak, and commenting out of some diskless tests that are not working on largefiles. These issues should be resolved before this PR is merged.)