-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unneeded object lookups... #1128
Merged
WardF
merged 23 commits into
Unidata:master
from
NetCDF-World-Domination-Council:ejh_hdf5_sep_next
Sep 14, 2018
Merged
Clean up unneeded object lookups... #1128
WardF
merged 23 commits into
Unidata:master
from
NetCDF-World-Domination-Council:ejh_hdf5_sep_next
Sep 14, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
@WardF if we could get these merged, I will put up the fixes for the benchmarking programs. It would be good to get the working benchmarks into the release, as I am starting to use them for HPC performance testing. |
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many cases in libhdf5 code we were doing an additional, unnecessary lookup for the NC *, which is not used in the libhdf5 code anyway. These are cleaned up in this PR. We still are doing two file lookups per call, one in the dispatch layer and one in libhdf5. (See my comment in #1056 for how this may be eliminated in a future effort.)
In nc4internal.c we had three different functions that did a file lookup, now nc4_find_nc_grp_h5() is where this code lives, and it accepts NULL parameters for whatever parameters the caller is not interested in (similar to nc_inq). The other functions are retained but now just call nc4_find_nc_grp_h5() with some NULLs.
The function nc4_rec_find_nc_type() has been eliminated - now the nclist functions are called directly. This matches usage with vars, groups, atts, and other nclist lists.
Also removed unnecessary initialization of some variables that do not need it. Although in many cases the compiler will strip these initializations, we don't want to add extra code or extra operations we don't need. Some of these functions may be called from some very deep loops.
Also documentation fixes.
Part of #965.
Part of #856.