-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move hid_t from NC_FILE_INFO_T to new struct NC_HDF5_FILE_INFO_T #1076
Move hid_t from NC_FILE_INFO_T to new struct NC_HDF5_FILE_INFO_T #1076
Conversation
appveyor builds failing like this:
I believe you just added ocprint to the CMake build. Probably you should just take it out. What seems to be happening is that it's expecting strings.h and not finding it in the Microsoft environment. Apparently it's found on Unix. |
I expect you may be right but I need to reconcile it with the lack of a failure on my dev platform e.g. where is it finding strings.h on my system and how do I bring this in line with a ‘standard’ install. |
That one is easy. Change |
@WardF can we get this merged? There are many more changes waiting in the queue... Thanks! |
@WardF can we get this merged please? |
Part of #856.
In this PR I remove the hid_t field hdfid from the NC_FILE_INFO_T structure. It is relocated to a new NC_HDF5_FILE_INFO_T struct, which exists only in libhdf5.
Similarly, all the hid_t types of the other metadata structs are going to move to new structs which will not be seen in libsrc4.
This PR is ready to merge.