Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent error handling in libsrc4/libhdf5 code #965

Closed
edhartnett opened this issue May 11, 2018 · 1 comment
Closed

inconsistent error handling in libsrc4/libhdf5 code #965

edhartnett opened this issue May 11, 2018 · 1 comment

Comments

@edhartnett
Copy link
Contributor

As noted by Dennis recently, the error handling in the netCDF-4 code is not always consistent.

After splitting the HDF5 code out, I will take a pass and clean up error handling everywhere.

Specifically, wherever we have resources to free, we should use the BAIL macro, or one of it's cousins, to ensure that resource get freed under all conditions.
This was referenced Jul 22, 2018
Closed
Closed
Merged
@edhartnett edhartnett mentioned this issue Aug 16, 2018
Merged
@edhartnett edhartnett mentioned this issue Aug 29, 2018
Merged
@edhartnett
Copy link
Contributor Author

I believe I have fixed all instances of this. If I see any more I will mention this ticket in the PR, but I will close the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edhartnett