Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup handling of NETCDF_ENABLE_SET_LOG_LEVEL and NETCDF_ENABLE_SET_LOG_LEVEL_FUNC #2931

Merged
merged 5 commits into from
Jun 7, 2024

Conversation

DennisHeimbigner
Copy link
Collaborator

The NETCDF_ENABLE_SET_LOG_LEVEL_FUNC option is apparently not used directly. But it is effectively used to set NETCDF_ENABLE_SET_LOG_LEVEL. This is not clear from the build files CMakeLists.txt and configure.ac. So this PR cleanups the code to make it more clear what is going on.

…_LOG_LEVEL_FUNC

The NETCDF_ENABLE_SET_LOG_LEVEL_FUNC option is apparently not used, but
is effectively used to set NETCDF_ENABLE_SET_LOG_LEVEL.
This is not clear from the build files CMakeLists.txt and configure.ac.
So this PR cleanups the code to make it more clear what is going on.
@DennisHeimbigner DennisHeimbigner requested a review from WardF as a code owner May 24, 2024 22:50
@WardF
Copy link
Member

WardF commented Jun 3, 2024

Looking at this, is there a reason not to just have NETCDF_ENABLE_LOGGING control the whole shebang? I can make that change, I'm just trying to figure out the usecase where we'd compile with logging but not want to enable nc_set_log_level.

@WardF WardF self-assigned this Jun 3, 2024
@WardF WardF added this to the 4.9.3 milestone Jun 3, 2024
@DennisHeimbigner
Copy link
Collaborator Author

I confess that the whole set of logging options is a bit opaque to me.
I would have agreed that having just a single option would make the most sense.
And no, I do not know of a use case for leaving set_level defined but do nothing.
So if you want to change it, I am ok with that, although it may take some unwinding.

@WardF WardF merged commit 6abcddb into Unidata:main Jun 7, 2024
106 checks passed
@DennisHeimbigner DennisHeimbigner deleted the loglevel.dmh branch June 20, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants