New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade H5Dcreate1() to H5Dcreate2() #1241

Closed

edhartnett opened this issue Dec 5, 2018 · 0 comments · Fixed by #1248

Contributor

edhartnett commented Dec 5, 2018

We use H5Dcreate2() in our code to create an ordinary dataset, but H5Dcreate1() when it's a dimscale dataset.

H5Dcreate1() is deprecated by HDF5 in favor of H5Dcreate2().

find libhdf5 -name '*.c'|xargs grep H5Dcreate
libhdf5/nc4hdf.c:   if ((hdf5_var->hdf_datasetid = H5Dcreate2(hdf5_grp->hdf_grpid, name_to_use, typeid,
libhdf5/nc4hdf.c:      if ((hdf5_dim->hdf_dimscaleid = H5Dcreate1(hdf5_grp->hdf_grpid, dim->hdr.name

Dimscales are already complicated enough, so I will upgrade the H5Dcreate1() to H5Dcreate2(). We will no longer use the deprecated H5Dcreate1().

The text was updated successfully, but these errors were encountered:

edhartnett mentioned this issue

Fix some issues, add comments, and prepare for lazy(-ish) var reads #1248

Merged

WardF closed this as completed in #1248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment