Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up functions create_group(), write_coord_dimids() in nc4hdf5.c #1082

Closed
edhartnett opened this issue Jul 22, 2018 · 0 comments
Closed

Clean up functions create_group(), write_coord_dimids() in nc4hdf5.c #1082

edhartnett opened this issue Jul 22, 2018 · 0 comments

Comments

@edhartnett
Copy link
Contributor

edhartnett commented Jul 22, 2018 •
edited
Loading

Part of #489.
Part of #965.

As part of the lazy vars work I cleaned up these functions. I will put up a PR with the changes when the queue clears out a bit.

Also NC4_del_att() in hdf5attr.c.
Also moved nc4typelen() from nc4hdf5.c to hdf5attr.c, the only place it is used, and made it static.
@edhartnett edhartnett changed the title Clean up function create_group() in nc4hdf5.c Clean up functions create_group(), write_coord_dimids() in nc4hdf5.c Jul 22, 2018
This was referenced Jul 24, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edhartnett