Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --lossy-unification globally? #1267

Open
fredrik-bakke opened this issue Feb 4, 2025 · 2 comments
Open

Enable --lossy-unification globally? #1267

fredrik-bakke opened this issue Feb 4, 2025 · 2 comments
Labels
question Further information is requested tooling

Comments

@fredrik-bakke
Copy link
Collaborator

Should we consider setting the --lossy-unification flag globally for the library? Degrading performance due to not enabling this flag is a recurring issue that new contributors face and lose a lot of time to, and potentially get frustrated by, especially in elementary-number-theory and real-numbers.

@fredrik-bakke fredrik-bakke added question Further information is requested tooling labels Feb 4, 2025
@EgbertRijke
Copy link
Collaborator

When we discussed this last time I thought we came to the conclusion that lossy unification doesn't speed up type checking globally, and the real gain is obtained on a case by case basis. Perhaps things have changed since the new Agda release came out, so we'd have to check again.

@fredrik-bakke
Copy link
Collaborator Author

fredrik-bakke commented Feb 4, 2025

The main benefit I see of enabling the flag globally is not about whether the overall type checking time would decrease, but rather that it lowers the bar for people who want to contribute to the library, and avoids unnecessary frustration and time-waste in the beginner phase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested tooling
Projects
None yet
Development

No branches or pull requests

2 participants