jpm run broken in firefox 47 beta 3 onwards

[trevj]

Not sure what's going on here but our tests are broken in Firefox 47 beta 3 onwards. *Not, weirdly in the 48 branch (yet).

On beta 2 I see this message:

DEPRECATION WARNING: This path to Console.jsm is deprecated.  Please use Cu.import("resource://gre/modules/Console.jsm") to load this module.
You may find more details about this deprecation at: https://bugzil.la/912121
resource://gre/modules/devtools/Console.jsm 19 null
resource://simple-socks/data/freedom-for-firefox/freedom-for-firefox.jsm 9117 require<[43]</<
resource://simple-socks/data/freedom-for-firefox/freedom-for-firefox.jsm 9112 require<[43]<
resource://simple-socks/data/freedom-for-firefox/freedom-for-firefox.jsm 22 s
resource://simple-socks/data/freedom-for-firefox/freedom-for-firefox.jsm 22 e
resource://simple-socks/data/freedom-for-firefox/freedom-for-firefox.jsm 22 null
resource://gre/modules/commonjs/toolkit/loader.js -> resource://simple-socks/index.js 5 null
resource://gre/modules/commonjs/toolkit/loader.js 279 evaluate
resource://gre/modules/commonjs/toolkit/loader.js 331 load
resource://gre/modules/commonjs/toolkit/loader.js 768 main
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/addon/runner.js 147 run
resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/commonjs/sdk/addon/runner.js 87 startup/</<
resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js 937 Handler.prototype.process
resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js 816 this.PromiseWalker.walkerLoop
resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js 750 this.PromiseWalker.scheduleWalkerLoop/<

[agallant]

I know you said you already tried this, but when I ran the simple socks demo with patched freedom-for-firefox (https://github.com/freedomjs/freedom-for-firefox/tree/soycode-consolepath) I didn't see this error message. I'll keep investigating, let me know if that works for you - thanks!

[trevj]

Having changed the path I no longer see the warning but Simple SOCKS still doesn't work.

Investigating some more, I see the problem is that, despite running Firefox via jpm run, the extension remains disabled because it's not verified (open about:addons). This page suggests the override would disappear in Firefox 47:
https://wiki.mozilla.org/Add-ons/Extension_Signing

Since there's no mention that jpm would suddenly stop working on official builds - and moving all our testing to developer edition builds (explains why our "canary" Docker runs still pass) is, um, inconvenient to say the least - I've opened a thread with the add-ons mailing list:
https://groups.google.com/forum/?fromgroups#!topic/mozilla-labs-jetpack/e0zaG1QyrRk

[jab]

Ugh, and nice work chasing this down.

[trevj]

Very happy to say I just tested this again and jpm seems to be working just fine in Firefox 47, 48, and 49. Must have been a bug in 47b3.

Bullet: dodged.

[trevj]

Happening again in 48b7!